Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to SHA256 #138 #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed to SHA256 #138 #147

wants to merge 2 commits into from

Conversation

peach280
Copy link

Changed MD5 hashes to SHA256. Please review and suggest improvements.

@peach280
Changed to SHA256
3f36912 
Signed-off-by: peach280 <[email protected]>
@ghutchis
Copy link
Member

I'll take a look later today or tomorrow -- sorry that I've been busy with a few other things.

@ghutchis ghutchis linked an issue Dec 19, 2024 that may be closed by this pull request
Switch to SHA256 hashes #138
Open
Krzmbrzl
Krzmbrzl suggested changes Dec 20, 2024
View reviewed changes
cmake/CMakeCache.txt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should bot be part of the PR

cmake/CMakeFiles/3.31.2/CMakeSystem.cmake Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should bot be part of the PR

cmake/CMakeFiles/CMakeConfigureLog.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should bot be part of the PR

cmake/CMakeFiles/cmake.check_cache Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should bot be part of the PR

@peach280
Copy link
Author

I have updated the changes please review.

Krzmbrzl
Krzmbrzl approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for what that's worth

@Krzmbrzl
Copy link
Contributor

Krzmbrzl commented Jan 3, 2025

Please stop spamming this PR. I don't have anything to say in this repo (I'm not a maintainer) and ghutchis clearly doesn't have any time at the moment or else he would have responded to your previous ping.

@ghutchis
Copy link
Member

ghutchis commented Jan 5, 2025

LGTM - I'm just not going to change anything right before we release 1.100. Call me superstitious. I'd guess that we release 1.100 sometime this coming week - waiting to hear back about a Windows bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krzmbrzl Krzmbrzl Krzmbrzl approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to SHA256 hashes
3 participants
@peach280 @ghutchis @Krzmbrzl